Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallet-proxy to runtimes #1322

Open
wants to merge 3 commits into
base: manta
Choose a base branch
from
Open

Add pallet-proxy to runtimes #1322

wants to merge 3 commits into from

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Mar 5, 2024

Description

Closes #1321

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Dengjianping Dengjianping self-assigned this Jun 14, 2024
@Dengjianping Dengjianping added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes L-added Log: Issues and PRs related to addition A-benchmark-checks A-integration-test-checks A-unit-test-checks labels Jun 14, 2024
@Dengjianping Dengjianping marked this pull request as ready for review June 14, 2024 08:18
Signed-off-by: Jamie <[email protected]>
Comment on lines +419 to +422
ProxyType::TransferNotDie => !matches!(
c,
RuntimeCall::Balances(pallet_balances::Call::transfer_allow_death { .. })
), // proxy account cannot transfer all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will allow all calls that are not pallet_balances::Call::transfer_allow_death { .. }, I don't think you can use the !matches pattern for that reason

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless I'm mistaken but I think we would want a sanity integration test

Copy link
Contributor Author

@Dengjianping Dengjianping Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fasle means the call will be filtered, so if it's the transfer_allow_death, !matches will be false. I guess it should be right. I will add a test case for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but any other call will be true, this means that TransferNotDie will allow you to act as a proxy for every other extrinsic except transfer_allow_death

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-unit-test-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proxy to calamari/manta runtime
2 participants